Seperate Row Highlights for songs

Post about feature requests here.
User avatar
James_S
Posts: 339
Joined: Tue Apr 21, 2015 12:37 am
Location: Chicago, IL

Seperate Row Highlights for songs

Postby James_S » Tue Aug 18, 2015 9:10 pm

As in, lets say one song is in 3/4 and uses the row highlight of 1st = 4 and 2nd = 12, and the next song is 4/4 and standard 4/16 in the same module.
Could this data be saved in the song so that FT remembers the row highlights for the individual songs without making old versions obsolete?
AKA FamicomForever
click for BEPIS!!!!

User avatar
HertzDevil
Posts: 475
Joined: Thu Apr 23, 2015 7:39 pm
Location: Hong Kong SAR
Contact:

Re: Seperate Row Highlights for songs

Postby HertzDevil » Tue Aug 18, 2015 9:28 pm

Code for this already appears in the 0.4.6 source code:

Code: Select all

bool CFamiTrackerDoc::ReadBlock_Header(CDocumentFile *pDocFile)
{
   // ...
   else if (Version >= 2) {
      // ...
      if (Version >= 4) {
         // Read highlight settings for tracks
         for (unsigned int i = 0; i < m_iTrackCount; ++i) {
            CPatternData *pTrack = GetTrack(i);
            // TODO read highlight
            int FirstHighlight = m_iFirstHighlight;
            int SecondHighlight = m_iSecondHighlight;
            //
            pTrack->SetHighlight(FirstHighlight, SecondHighlight);
         }
      }
Since 0.5.0 beta 1 and onward uses version 4 for the HEADER block, it means that this feature is already implemented in every 0.5.0 beta. It does not seem the OP of the 0.5.0 beta thread mentions this at all. There is no way to make this feature backward-compatible since the row highlight info is completely removed from the PARAMS block.

Please lock this thread.
refactoring 0cc-famitracker

User avatar
jrlepage
Forum Staff
Posts: 237
Joined: Wed Apr 15, 2015 11:25 am
Location: Quebec, Canada
Contact:

Re: Seperate Row Highlights for songs

Postby jrlepage » Fri Aug 21, 2015 3:04 am

HertzDevil wrote:Please lock this thread.

Please don't backseat moderate.
Follow me on Twitter.

Threxx
Posts: 343
Joined: Wed Apr 22, 2015 2:34 pm
Location: Brooklyn, NY
Contact:

Re: Seperate Row Highlights for songs

Postby Threxx » Fri Aug 21, 2015 3:34 am

To be perfectly fair, now that the question has been answered and the feature is known to be implemented for the next build, there is no reason for this thread to stay open any longer.


Return to “Feature Requests”

Who is online

Users browsing this forum: No registered users and 1 guest